Skip to content

pattern matching via regex#4

Open
artfwo wants to merge 8 commits into
wrl:masterfrom
artfwo:regex-pattern-matching
Open

pattern matching via regex#4
artfwo wants to merge 8 commits into
wrl:masterfrom
artfwo:regex-pattern-matching

Conversation

@artfwo

@artfwo artfwo commented Oct 15, 2017

Copy link
Copy Markdown

basic pattern matching. this implementation translates osc address patterns to regular expressions and provides a method for matching messages against the latter.

@wrl

wrl commented Oct 15, 2017

Copy link
Copy Markdown
Owner

Hey, thanks for taking the initiative on this! I have a few things I'd like to see addressed before merging, if they're not too much trouble. First, I'd prefer that the regex dependency is pinned at least to "0.2" to avoid potential breakage in the future. And second, would you mind adding additional tests for the other special OSC pattern characters?

@artfwo

artfwo commented Oct 16, 2017

Copy link
Copy Markdown
Author

@wrl, on it :)

@artfwo artfwo force-pushed the regex-pattern-matching branch from cebe302 to 0a630f2 Compare November 14, 2017 03:53
@artfwo

artfwo commented Nov 15, 2017

Copy link
Copy Markdown
Author

@wrl ok, added a few tests and some additional checks in the translator, looks good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants