Skip to content

Fix positions history & candles optional fields definition (STARKNET) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ex10ded merged 1 commit into from
Jun 23, 2025
Merged

Fix positions history & candles optional fields definition (STARKNET) #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "x10-python-trading-starknet"
version = "0.0.3"
version = "0.0.4"
description = "Python client for X10 API"
authors = ["X10 <tech@ex10.org>"]
repository = "https://github.com/x10xchange/python_sdk"
Expand Down
6 changes: 4 additions & 2 deletions x10/perpetual/candles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from decimal import Decimal
from typing import Literal
from typing import Literal, Optional

from pydantic import AliasChoices, Field

Expand All @@ -14,5 +14,7 @@ class CandleModel(X10BaseModel):
low: Decimal = Field(validation_alias=AliasChoices("low", "l"), serialization_alias="l")
high: Decimal = Field(validation_alias=AliasChoices("high", "h"), serialization_alias="h")
close: Decimal = Field(validation_alias=AliasChoices("close", "c"), serialization_alias="c")
volume: Decimal = Field(validation_alias=AliasChoices("volume", "v"), serialization_alias="v")
volume: Optional[Decimal] = Field(
validation_alias=AliasChoices("volume", "v"), serialization_alias="v", default=None
)
timestamp: int = Field(validation_alias=AliasChoices("timestamp", "T"), serialization_alias="T")
6 changes: 3 additions & 3 deletions x10/perpetual/positions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ class PositionHistoryModel(X10BaseModel):
leverage: Decimal
size: Decimal
open_price: Decimal
exit_type: Optional[ExitType]
exit_price: Optional[Decimal]
exit_type: Optional[ExitType] = None
exit_price: Optional[Decimal] = None
realised_pnl: Decimal
created_time: int
closed_time: Optional[int]
closed_time: Optional[int] = None
8 changes: 4 additions & 4 deletions x10/perpetual/trading_client/order_management_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@


class _MassCancelRequestModel(X10BaseModel):
order_ids: Optional[List[int]]
external_order_ids: Optional[List[str]]
markets: Optional[List[str]]
cancel_all: Optional[bool]
order_ids: Optional[List[int]] = None
external_order_ids: Optional[List[str]] = None
markets: Optional[List[str]] = None
cancel_all: Optional[bool] = None


class OrderManagementModule(BaseModule):
Expand Down