This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Improve logging for failed TCP connections due to hostname - #51
Merged
Conversation
akoeplinger
reviewed
Aug 14, 2019
| } catch (Exception) { | ||
| } catch (Exception e) { | ||
| lock (lock_obj) { | ||
| Console.WriteLine ("TCP connection failed when selecting 'hostname': {0}", e); |
spouliot
suggested changes
Aug 14, 2019
spouliot
left a comment
Contributor
There was a problem hiding this comment.
agreed with @akoeplinger the port can be useful too
Contributor
Author
|
Fair comments, new logging looks like this: |
spouliot
approved these changes
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new improved logging adds this bit of info to the run logs:
It's especially useful to debug issues, notably: https://github.com/xamarin/maccore/issues/1741