This repository was archived by the owner on Jan 10, 2025. It is now read-only.
[TouchRunner] Fix colors for iOS 13 dark mode - #53
Merged
spouliot merged 3 commits intoSep 13, 2019
Conversation
Contributor
Author
|
|
Contributor
Author
|
@spouliot those APIs are iOS 13+ I think so we might want to hold the merge for a bit. |
Member
|
If these API are iOS 13+ only, I think it would be best to add version checks (try running introspection on iOS 10.3 for instance to see how well it works). |
Contributor
Author
|
@rolfbjarne you were right, fixed |
rolfbjarne
approved these changes
Sep 13, 2019
spouliot
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we fully support light and dark modes. Before that we'd show the tests in black https://github.com/migueldeicaza/MonoTouch.Dialog/blob/98c2a56eaf37a483b47f12599675e41b91319d38/MonoTouch.Dialog/Elements.cs#L879 and that didn't play nice with dark mode (: