This repository was archived by the owner on Jan 10, 2025. It is now read-only.
[TouchRunner] Only update the UI for a single test after the test has finished running. - #72
Merged
Merged
Conversation
… finished running. Only update the UI for a single test after we're notified that the test has finished running. This is a step towards making async tests work properly, where we can't assume that the test has finished after calling Run. Also we only want to show more details for a test if we ran that test as a result of tapping on it.
spouliot
approved these changes
Jul 14, 2020
rolfbjarne
added a commit
that referenced
this pull request
Jul 14, 2020
… finished running. (#72) Only update the UI for a single test after we're notified that the test has finished running. This is a step towards making async tests work properly, where we can't assume that the test has finished after calling Run. Also we only want to show more details for a test if we ran that test as a result of tapping on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only update the UI for a single test after we're notified that the test has
finished running. This is a step towards making async tests work properly,
where we can't assume that the test has finished after calling Run.
Also we only want to show more details for a test if we ran that test as a
result of tapping on it.