CA-425192/CP-311612/CP-311613: backport quicktest SMAPIv3 fixes to LCM branch#6959
Merged
edwintorok merged 2 commits intoxapi-project:26.1-lcmfrom Mar 20, 2026
Merged
CA-425192/CP-311612/CP-311613: backport quicktest SMAPIv3 fixes to LCM branch#6959edwintorok merged 2 commits intoxapi-project:26.1-lcmfrom
edwintorok merged 2 commits intoxapi-project:26.1-lcmfrom
Conversation
This seems to be a SMAPIv1 specific implementation detail (content_id in VDI.other-config), that is missing on SMAPIv3 SRs. The rest of the test works on SMAPIv3, so skip just this step. Signed-off-by: Edwin Török <edwin.torok@citrix.com> (cherry picked from commit ceebe4b)
VHD export takes various shortcuts, and delta export only works if the source is also VHD.
Otherwise it fails with:
`Failure("Cannot compute differences on non-VHD images")`
If the source is already qcow2, like for SMAPIv3, then this is not (yet)
expected to work, so skip those tests on SMAPIv3 for now.
Note that regular export works, it is just the delta export that fails (specifying `base=`
in `xe vdi-export`).
Signed-off-by: Edwin Török <edwin.torok@citrix.com>
(cherry picked from commit 8ac4476)
psafont
approved these changes
Mar 19, 2026
last-genius
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #6908 to the LCM branch.
These latent bugs have existed in the tests for a long time, but previously our test system (XenRT) picked machines randomly, so it would've been unlikely to pick a machine which has a local 4K SR (SMAPIv3 instead of SMAPIv1), and even if it did, the test would seemingly pass on a rerun (because another machine would get picked).
We are now explicitly running the test multiple times on different hardware categories, and some of those tests are now failing 100% of the time.