Conversation
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@cloud.com>
|
Noting explicitly that this PR addresses #6960. Thanks. |
| public string[] OpaqueRef { get; set; } | ||
|
|
||
| [Parameter] | ||
| public string Originator { get; set; } = "XenServerPSModule/" + Helper.APIVersionString(API_Version.LATEST); |
There was a problem hiding this comment.
In telemetry , PM want to collect this user-agent key "XenServerPSModule/" to know how many customer use PS SDK, if this remove and use DefaultUserAgent = $"XenAPI/{Helper.APIVersionString(API_Version.LATEST)}";, the upload telemetry data will not as we expected.
https://github.com/csg-xenserver/xenserver-telemetry/blob/master/plugin/xenserver_telemetry.py#L54C1-L54C22
suggest keep string "XenServerPSModule" in user agent.
There was a problem hiding this comment.
The UserAgent is meant to be set by the calling code. Strictly speaking, "XenServerPSModule/XenAPIversion" is not correct, because the module is versioned after the xapi tag; this is the reason why I changed it. If we want to keep the "XenServerPSModule/" bit, we probably need to add a placeholder in the string and replace it at build time like we do in the .psd1 file.
There was a problem hiding this comment.
I replaced it both for C# and PS with a string that contains the placeholder.
The API version will be bumped later, hence I am not including it in this PR.
|
For the file change for XS9 in https://github.com/csg-xenserver/xencenter/blob/master/XenModel/XenAPI/ApiVersion.cs#L93 do we need to update in SDK temple? |
…ault value. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Made methods JsonRpc.Rpc() and JsonRpc.CreateSerializer() protected. - Deprecated a number of instance Session methods in favour of the static counterparts. - Removed property Session.Roles (which was a XenCenter-ism) - Corrected the output of Session.get_record and the return type of Session.logout_subject_identifier - Session.change_password(Session, string, string) is now static. - Fields Session.Proxy, Session.Tag, Session.APIVersion were converted to properties. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
… /vm_rrd are already exposed. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
…rsion to 17 (LTS) Signed-off-by: Konstantina Chremmou <konstantina.chremmou@cloud.com> Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
…mporting the module. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The commits in this PR are exactly the same as in PR #6988 , they applied cleanly on this branch.
5 participants
There is a minor change in the datamodel, the rest are SDK files. These changes will need porting to
26.1-lcmafterwards.