CA-425472: Signal correct daemon during log rotation#7007
Merged
lindig merged 1 commit intoxapi-project:masterfrom Apr 15, 2026
Merged
CA-425472: Signal correct daemon during log rotation#7007lindig merged 1 commit intoxapi-project:masterfrom
lindig merged 1 commit intoxapi-project:masterfrom
Conversation
/var/run/syslogd.pid file does not exist in XS9. Signed-off-by: Frediano Ziglio <frediano.ziglio@citrix.com>
lindig
approved these changes
Apr 13, 2026
lindig
approved these changes
Apr 13, 2026
| /var/log/xcp-rrdd-plugins.log { | ||
| postrotate | ||
| /bin/kill -HUP `cat /var/run/syslogd.pid 2> /dev/null` 2> /dev/null || true | ||
| /usr/bin/systemctl kill -s HUP rsyslog.service >/dev/null 2>&1 || true |
Contributor
There was a problem hiding this comment.
Why are we keeping the || true which is masking errors? Are we not always expecting this to succeed?
Collaborator
Author
There was a problem hiding this comment.
I suppose mainly for coherency. It should fail for missing service (not an issue if the service is stopper) or something very weird.
Personally I would keep just to avoid possible regressions.
minglumlu
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/var/run/syslogd.pid file does not exist in XS9.