Skip to content

Accept VRTUnsupportedError in resample-alg rejection test #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendancol merged 1 commit into from
May 25, 2026
+9 −6
Merged

Accept VRTUnsupportedError in resample-alg rejection test #2378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions xrspatial/geotiff/tests/test_vrt_unsupported_2370.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,11 +433,14 @@ def test_complex_mask_source_raises(tmp_path):
@pytest.mark.parametrize('alg', ['Bilinear', 'Cubic', 'Lanczos',
'Average', 'Mode'])
def test_unsupported_resample_alg_raises(tmp_path, alg):
"""Already enforced by issue #1751: a ``<ResampleAlg>`` value
outside the implemented nearest subset, paired with size-changing
SrcRect/DstRect rects, raises ``NotImplementedError`` with the
algorithm name in the message. Lock that contract in here so the
rejection survives any future refactor.
"""A ``<ResampleAlg>`` value outside the implemented nearest subset,
paired with size-changing SrcRect/DstRect rects, is rejected with
the algorithm name in the message. The legacy resample-site check
(#1751) raises ``NotImplementedError``; the centralised validator
(#2329) raises ``VRTUnsupportedError`` (a ``ValueError`` subclass)
at parse time. Either is a valid rejection so long as the message
names the offending algorithm -- matches the dual-type contract in
``test_unsupported_resample_alg_open_geotiff``.
"""
src_path = _write_src_tif(tmp_path, name=f'res_{alg.lower()}')
inner = f'<ResampleAlg>{alg}</ResampleAlg>'
Expand All @@ -453,7 +456,7 @@ def test_unsupported_resample_alg_raises(tmp_path, alg):
xml = _vrt_xml(width=2, height=2, body=body)
vrt_path = _write_vrt(tmp_path, xml, f'resample_{alg.lower()}')

with pytest.raises(NotImplementedError) as excinfo:
with pytest.raises((NotImplementedError, ValueError)) as excinfo:
read_vrt(vrt_path)
msg = str(excinfo.value)
assert alg in msg, f"error must name the rejected algorithm: {msg!r}"
Expand Down
Loading