makefile: Support cross compile#7
Merged
Merged
Conversation
Signed-off-by: DAEYEONG LEE <daeyeong.lee@metisx.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enables cross-compilation of kernel modules by updating the Makefile and installation scripts.
- Updates install.sh to use the modern subshell syntax for determining the number of processors and adds a depmod invocation.
- Modifies the Makefile to support specifying BUILDSYSTEM_DIR, kernel version, and an optional installation path, and overrides DEPMOD during install.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| install.sh | Updated to use $(nproc) instead of backticks and adds depmod. |
| Makefile | Now allows cross compilation with configurable paths and settings. |
Comments suppressed due to low confidence (1)
Makefile:9
- Consider adding a comment to explain the removal of the conditional debug flag block so that future maintainers understand its intentional omission in cross compile scenarios.
ifneq ($(DEBUG),)
| install: all | ||
| $(MAKE) -C $(BUILDSYSTEM_DIR) M=$(PWD) modules_install | ||
| depmod -a | ||
| $(MAKE) -C $(BUILDSYSTEM_DIR) M=$(PWD) modules_install $(INSTALL_MOD_PATH_ARG) DEPMOD=/bin/true |
There was a problem hiding this comment.
Please add a comment explaining the override of DEPMOD to '/bin/true' to clarify its purpose in the cross compile context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
수정 사항