Skip to content

Release #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AB-xdev merged 4 commits into from
Dec 2, 2025
Merged

Release #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5e02b2
Merge pull request #233 from xdev-software/master
AB-xdev Dec 2, 2025
c6cd415
Cleanup
AB-xdev Dec 2, 2025
d698062
Increase default recording save time buffer a bit
AB-xdev Dec 2, 2025
be2e69d
Update CHANGELOG.md
AB-xdev Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 1.5.1
* Slightly increased default recording save wait time a bit

# 1.5.0
* No longer map timezone into container by default
* This should keep tests consistent
Expand Down
6 changes: 3 additions & 3 deletions ...a/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public class BrowserWebDriverContainer<SELF extends BrowserWebDriverContainer<SE

protected static Boolean currentOsWindows; // You should use the method instead, this might be NULL

protected boolean mapTimezoneIntoContainer = false;
protected boolean mapTimezoneIntoContainer;

protected boolean validateImageEnabled = true;
protected Duration validateImageGetTimeout = Duration.ofMinutes(5);
Expand All @@ -114,8 +114,8 @@ public class BrowserWebDriverContainer<SELF extends BrowserWebDriverContainer<SE
protected Path recordingDirectory;
protected TestRecordingFileNameFactory testRecordingFileNameFactory = new DefaultTestRecordingFileNameFactory();
protected Duration recordingSaveTimeout = Duration.ofMinutes(3);
// Ensure that the current frame will be fully recorded (default record FPS = 15 -> 67ms per Frame)
protected Duration beforeRecordingSaveWaitTime = Duration.ofMillis(70);
// Ensure that the current frame will be fully recorded (default record FPS = 15 -> 67ms per Frame + some buffer)
protected Duration beforeRecordingSaveWaitTime = Duration.ofMillis(100);

public BrowserWebDriverContainer(final String dockerImageName)
{
Expand Down