This repository was archived by the owner on Apr 5, 2020. It is now read-only.
Fix for global exception handling.#22
Merged
Merged
Conversation
Member
|
+1, we should have some tests for this |
Member
|
Released in v8.4.5, thanks @johannes85! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since in the end, the handler is called by this function:
return false === $r ? $r : $invocation->proceed($request, $response);Every unhandled exception thrown in the handler will be converted into an ScriptletException with the "forbidden" error code.
This breaks the global error handling.
As a solution, I moved the call to an position outside of the try..catch block, in the assumtion that the error handling only is relevant for the "authenticate" call.