Use Yoast deprecated method conditionally#1603
Merged
marcinkrzeminski merged 4 commits intodevelopfrom Oct 10, 2024
Conversation
pereirinha
approved these changes
Oct 10, 2024
Contributor
pereirinha
left a comment
There was a problem hiding this comment.
I've tested this with Yoast 23.6, and it's working as expected. No more deprecated warnings in the logs.
The only non-blocking suggestion would be to update the Yoast plugin so that the issue becomes more prominent.
Contributor
|
Hi! Will this be included in a new Stream release soon? It would be nice to be rid of those deprecation notices. |
Contributor
Author
|
Hey @westonruter. Yeah, it's part of 4.1 release that's coming soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1594
Checklist
contributing.md).Release Changelog
\WPSEO_Metabox::translate_meta_boxes()conditionally to prevent logging warnings.