Skip to content

Theme Edits Grayed Out#1658

Merged
marcinkrzeminski merged 8 commits intodevelopfrom
fix/1657-theme-edits-grayed-out
Dec 31, 2024
Merged

Theme Edits Grayed Out#1658
marcinkrzeminski merged 8 commits intodevelopfrom
fix/1657-theme-edits-grayed-out

Conversation

@marcinkrzeminski
Copy link
Contributor

@marcinkrzeminski marcinkrzeminski commented Dec 20, 2024

Fixes #1657

Use alternative hook to track the theme files updates in the Dashboard.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix Theme files changes are tracked as expected

@marcinkrzeminski marcinkrzeminski changed the title Fix/1657 theme edits grayed out 1657 Theme Edits Grayed Out Dec 20, 2024
@marcinkrzeminski marcinkrzeminski changed the title 1657 Theme Edits Grayed Out Theme Edits Grayed Out Dec 20, 2024
Copy link
Contributor

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but this looks good. I looked it up and the ajax method was added in 4.9 so I think we're safe? It will still work with < WP 4.9 but won't record the changes.

Should we add a "Requires at least" header? I'm not really sure which version that would be though.

Copy link
Contributor

@tharsheblows tharsheblows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It all looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theme Edits Grayed Out

2 participants