Fix several YapDatabaseRelationship extension bugs#399
Closed
JimRoepcke wants to merge 5 commits into
Closed
Conversation
…assertion in -deleteEdge: (this only addresses manual edges, protocol edges were not audited)
cdzombak
reviewed
May 1, 2017
| if (!(edge->state & YDB_EdgeState_HasEdgeRowid)) | ||
| { | ||
| edge->flags |= YDB_EdgeFlags_EdgeNotInDatabase; | ||
| } |
There was a problem hiding this comment.
Throughout this file, it looks like the additions are indented with spaces, but the existing code uses tabs.
Contributor
|
Thank you! Merged into "v3.0" branch. |
robbiehanson
added a commit
that referenced
this pull request
Nov 25, 2017
robbiehanson
added a commit
that referenced
this pull request
Mar 8, 2018
…otocolEdges instead of manualEdges. Added corresponding unit test as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
edgeCachewas getting corrupted by some incorrect SQLite column offsets, which was resulting in edges being returned with invalid destination and delete rules.Also, when deleting edges that were just added, the NotInDatabase flag wasn't being set in all cases leading to an assertion in
-deleteEdge:failing. Note that this commit only addresses this issue for manual edges - I'm not using protocol edges and didn't feel comfortable modifying the code in the preprocessProtocolEdges method yet.This includes a commit from the 3.0 branch that fixes a minor bug