Fixed build errors and bad project references#404
Conversation
Some of the Xcode group folders were misnamed. YapDatabaseAutoView wasn't added to the xcodeproj. Updated modulemaps to include YapDatabaseAutoView.
|
Thank you ! |
I fixed this in the code. If I remember correctly, the NSIndexPath.row & NSIndexPath.section were available properties on iOS via a category class. But I don't see them anymore. So perhaps they got moved into UIKit. Whatever the case, it was safe to always use the alternative code, which accomplishes the same thing. Also, I removed the references to the Reachability.framework, which is no longer needed. And fixed the references to the CocoaLumberjack.framework. Hopefully there aren't any incompatibilities between Xcode versions, and I ended up stepping on your toes. |
|
Thanks! Correct, the NSIndexPath category is in UIKit (don't know if that changed between the iOS 10 and 11 SDKs). |
I was getting build errors with a fresh clone of the repository and Xcode 9. This fixes the builds for Mac, watchOS, and tvOS.
iOS is still failing because an error in YapDatabaseViewTransaction (it can't find NSIndexPath row or section), that seems to be separate from purely xcodeproj/module errors though.