Replace OSSpinLock with os_unfair_lock when building for macOS 10.12,…#410
Merged
Conversation
… iOS 10.0, watchOS 3.0 or tvOS 10.0. OSSpinLock is deprecated and should be replaced by os_unfair_lock. However, os_unfair_lock is not available prior to the aforementioned platforms. Added some defined to seamlessly map between OSSpinLock and os_unfair_lock in YapDatabaseAtomic.h. YapDatabase deploys to earlier versions so OSSpinLock is still used by default. But if consumers of the framework decide to rebuild it for more modern platforms, os_unfair_lock will be used.
Contributor
|
Perfect ! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… iOS 10.0, watchOS 3.0 or tvOS 10.0.
OSSpinLock is deprecated and should be replaced by os_unfair_lock. However, os_unfair_lock is not available prior to the aforementioned platforms. Added some defined to seamlessly map between OSSpinLock and os_unfair_lock in YapDatabaseAtomic.h.
YapDatabase deploys to earlier versions so OSSpinLock is still used by default. But if consumers of the framework decide to rebuild it for more modern platforms, os_unfair_lock will be used.
I've added the file YapDatabaseAtomic.h, because it didn't really fit in any of the other headers. It could maybe be moved to YapDatabasePrivate.h, but I think a new header is more fitting.