Block arguments decorated w/ NS_NOESCAPE where appropriate#486
Merged
Conversation
Contributor
|
Very cool. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #175
Objective-C closures are implicitly escaping, Swift closures are implicitly non-escaping 🤦♂️
For Swift projects using YapDB, if you create a func that has a closure argument, and that closure is then passed to a YapDB method (e.g. to synchronously enumerate something), you'll need to mark that closure as escaping, even though the method you're calling doesn't actually need it to be escaping.
Decorating the Objective-C block arguments w/ NS_NOESCAPE clarifies to the caller that no, the thing you're calling will not be hanging onto the closure you're passing it. Unless it's asynchronous, or the closure is actually stored (e.g. group blocks/sorting blocks/search handler blocks/etc), it doesn't need to be escaping.