feat: migrate to pnpm#132
Merged
Merged
Conversation
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
WybeBosch,
Yannicvanveen,
laravdiemen and
rivanuff
YvetteNikolov
changed the title
There was a problem hiding this comment.
Pull request overview
This PR migrates the monorepo’s workspace tooling from npm/yarn workspaces to pnpm, aligning dependency management scripts and workspace configuration to pnpm’s model.
Changes:
- Added
pnpm-workspace.yamlto define the workspace package globs. - Updated root
package.jsonto pin the pnpm version viapackageManagerand switched dependency maintenance scripts to pnpm equivalents. - Updated Lerna configuration to use pnpm and added a missing runtime dependency (
chalk) to@yardinternet/vite-configfor pnpm’s strict dependency resolution.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Defines workspace package locations for pnpm. |
| packages/vite-config/package.json | Adds chalk to ensure vite-config declares its direct dependency under pnpm. |
| package.json | Pins pnpm via packageManager and updates dependency management scripts to pnpm commands. |
| lerna.json | Switches Lerna to pnpm (and should explicitly define package globs to ensure package discovery). |
Comment on lines
2
to
5
| "$schema": "node_modules/lerna/schemas/lerna-schema.json", | ||
| "version": "independent", | ||
| "npmClient": "pnpm", | ||
| "command": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.