modifications of autostart and firefox#102
Merged
ydkhatri merged 3 commits intoydkhatri:masterfrom Jul 20, 2023
a5hlynx:master
Merged
modifications of autostart and firefox#102ydkhatri merged 3 commits intoydkhatri:masterfrom a5hlynx:master
ydkhatri merged 3 commits intoydkhatri:masterfrom
a5hlynx:master
Conversation
… mac_apt on windows.
Owner
|
Thanks, will review this tonight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I notice that mac_apt does not process BackgroundItems-v*.btm and firefox artifacts when it is executed on windows.
I found both caused by the difference in path separetor between mac and windows.
I modified autostart.py and firefox.py so that they can process those artifacts.
If the modifications seem OK to you, would you merge them?