add set_if_changed(Attributes) and hydrate(trait Apply) methods#4158
Open
tikitko wants to merge 2 commits into
Conversation
… attribute handling
Benchmark - coreYew MasterPull Request |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
…add deprecation notice for hydrate method
|
Visit the preview URL for this PR (updated for commit 7fe55ee): https://yew-rs-api--pr4158-img-src-re-downloade-7cvcwxmv.web.app (expires Sat, 23 May 2026 12:58:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Contributor
Author
|
I checked Leptos - they skip setting attributes entirely on hydrate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce an optimized hydration path for DOM attributes - skip unnecessary set_attribute calls when SSR has already written the correct value.
Fixes #4157
Checklist