Skip to content

Psalm 1 + Improve HeaderValueHelper methods annotations#45

Merged
vjik merged 3 commits into
masterfrom
improve-annotation
Jun 8, 2023
Merged

Psalm 1 + Improve HeaderValueHelper methods annotations#45
vjik merged 3 commits into
masterfrom
improve-annotation

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented Apr 30, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Apr 30, 2023

PR Summary

  • Improve code analysis configuration
    Update settings to suppress irrelevant error messages
  • Enhance type annotations for getSortedValueAndParameters method
    Improve type annotations for method returns, providing easier implementation understanding
  • Refine docblock comments in HeaderValueHelper
    Enhance existing method documentation for better developer comprehension
  • Remove redundant check in HeaderValueHelper::getSortedValueAndParameters
    Eliminate unnecessary checks as syntax analysis tool already performs the check
  • Ensure proper data type for iterating in HeaderValueHelper methods
    Force the use of arrays as input for better compatibility and error prevention

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (2023fd8) 99.12% compared to head (3699492) 99.17%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
+ Coverage     99.12%   99.17%   +0.05%     
- Complexity       45       46       +1     
============================================
  Files             2        2              
  Lines           114      121       +7     
============================================
+ Hits            113      120       +7     
  Misses            1        1              
Impacted Files Coverage Δ
src/HeaderValueHelper.php 98.96% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik requested a review from a team April 30, 2023 17:04
@vjik vjik added the status:code review The pull request needs review. label Apr 30, 2023
@vjik vjik merged commit 662b3c7 into master Jun 8, 2023
@vjik vjik deleted the improve-annotation branch June 8, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants