Skip to content

Implement file name transliteration and remove yiisoft/strings dependency#59

Merged
vjik merged 5 commits into
masterfrom
fallback-name-creator
May 16, 2025
Merged

Implement file name transliteration and remove yiisoft/strings dependency#59
vjik merged 5 commits into
masterfrom
fallback-name-creator

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented May 12, 2025

Q A
Is bugfix?
New feature?
Breaks BC?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.42%. Comparing base (3f41dbc) to head (44ba536).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/FallbackNameCreator.php 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
- Coverage     99.17%   98.42%   -0.75%     
- Complexity       44       47       +3     
============================================
  Files             2        3       +1     
  Lines           121      127       +6     
============================================
+ Hits            120      125       +5     
- Misses            1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team May 12, 2025 12:53
@vjik vjik added the status:code review The pull request needs review. label May 12, 2025
@samdark
Copy link
Copy Markdown
Member

samdark commented May 15, 2025

Is the only purpose to eliminate dependency?

@vjik
Copy link
Copy Markdown
Member Author

vjik commented May 15, 2025

Is the only purpose to eliminate dependency?

yes

Copy link
Copy Markdown
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Let it be.

@vjik vjik merged commit d8eaba3 into master May 16, 2025
29 of 31 checks passed
@vjik vjik deleted the fallback-name-creator branch May 16, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants