Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

General/Hiero: better clip duration calculation#3169

Merged
jakubjezek001 merged 2 commits into
developfrom
bugfix/framerange_op_wrong_duration
May 18, 2022
Merged

General/Hiero: better clip duration calculation#3169
jakubjezek001 merged 2 commits into
developfrom
bugfix/framerange_op_wrong_duration

Conversation

@jakubjezek001
Copy link
Copy Markdown
Member

Brief description

Improving clip duration calculation

Description

Frame duration should not be excluding one frame as it is disturbing other hosts. Better to fix it in global then hack particular dcc (flame)

Testing notes:

  1. open your testing hiero script
  2. publish a clip
  3. all should look as expected

@jakubjezek001 jakubjezek001 self-assigned this May 12, 2022
@jakubjezek001 jakubjezek001 added host: Hiero type: bug Something isn't working labels May 12, 2022
@jrsndl
Copy link
Copy Markdown
Collaborator

jrsndl commented May 14, 2022

Not quite sure how to properly check the duration. I compared published OTIO from Hiero to old one, and found the durations the same and correct.

@mkolar
Copy link
Copy Markdown
Member

mkolar commented May 16, 2022

This is certainly a better approach

@jakubjezek001 jakubjezek001 merged commit 373930c into develop May 18, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/framerange_op_wrong_duration branch May 18, 2022 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

host: Hiero type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants