This repository was archived by the owner on Sep 20, 2024. It is now read-only.
General: Creator plugins from addons can be registered#3179
Merged
Conversation
Contributor
|
Task linked: OP-3220 Creators in Addons issues |
kalisp
approved these changes
May 17, 2022
Member
kalisp
left a comment
There was a problem hiding this comment.
Working for creator in add on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
Addons can register creator plugin paths and Creators can have host name filter.
Description
Creator plugins have host name filtering so e.g. tray publisher creators won't appear in other hosts. Addon can implement new method which return creator plugin paths for specific host name. Default implementation is using
get_plugin_pathsfor backwards compatibility. Installation of openpype plugins will also register creators from modules. Creator plugin has also ability to define host name filter.Additional information
We wanted to have filtering ability of creator plugins on both addon and creator side so creator plugin has
host_nameattribute which can define on which host is working. This is for backwards compatibility not abstract. But it is a question if it should be required? In most of cases it is only matter of addon implementation where this filter is "required" (It probably won't happen that host on it's own will register plugins for different host). Also at this time are new creators used only in 3 hosts so it could be easy to change it.Testing notes:
IPluginPathsget_creator_plugin_pathswhich returns path to the creator dirResolves #3165