Loader UI: Speed issues of loader with sync server#3199
Conversation
|
Task linked: OP-3261 Loader speed issues |
| remote_provider = 'studio' | ||
|
|
||
| repre_icons = lib.get_repre_icons() | ||
| repre_icons = lib.get_repre_icons() |
There was a problem hiding this comment.
Would you want to cache this too? Or isn't this called as frequently?
There was a problem hiding this comment.
I don't know. I just made quick fix so it's usable in production...
|
I feel like this caching mechanic should somehow actually be IN the Site Sync module and directly in the Loader. Like maybe be a class loaded from the Module and used in the Loader so that the logic is where its closer related to? Hmm - not sure it's easily doable now. But maybe something to note for the future to see if we can separate this better. |
If we are merging this lets keep an issue open somewhere to remind us of doing that cleanup. |
I would say that not. This is logic using Sync server, but it is Loader tool specific. Hard to tell at this moment. Proper fix will need a lot of work before we get there.
Opened #3201 |
6 participants
Brief description
A little bit enhanced loader UI speec when sync server is enabled.
Description
Cache sync server related information for some time to avoid refresh of sync server on each selection change.
Additional info
Loader was refreshing sync server module, it's setting for all projects on each change of context in loader UI which is also happening separatelly for subset widget and representation widget.
This is a "quick" change, full fix would require to modify some logic in sync server and partially rewrite how loader UI logic works.
Testing notes:
Loader didn't change but should be faster when sync server is enabled.