Skip to content

docs(claude): PR 作成後の追従ルール追加と失敗知見の scoped rule 化#398

Merged
yusuke0610 merged 1 commit into
mainfrom
docs/claude-pr-followup-rules-split
Jun 22, 2026
Merged

docs(claude): PR 作成後の追従ルール追加と失敗知見の scoped rule 化#398
yusuke0610 merged 1 commit into
mainfrom
docs/claude-pr-followup-rules-split

Conversation

@yusuke0610

@yusuke0610 yusuke0610 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

概要

.claude/ の AI ガイドラインのみの変更です(アプリコードの変更なし=コード CI 対象外)。

  1. PR 作成後の追従ルールを追加: CLAUDE.md「コミット / PR フロー」に、PR 作成後は CI 結果とレビュー指摘を追従し、こけ・指摘があれば修正→make ci→再 push を green かつ解消まで繰り返す旨を追記。ただし意思決定を要する指摘(設計・API/型契約・挙動変更)と diff 範囲を逸脱する指摘は勝手に直さず承認を取る、範囲内の機械的修正は承認不要、と明記。

  2. 「失敗から学んだ知見」を scoped rule 化: 領域固有の項目を、対象パス編集時に自動ロードされる各 scoped rule へ移設し、CLAUDE.md 側は索引に集約。常時ロードされる CLAUDE.md を 211→194 行に縮小しつつ、backend 固有の詳細は backend 編集時のみロードされるよう整理。

変更詳細

ファイル 変更
CLAUDE.md PR 後追従ルール追記 / 失敗知見セクションを索引化
rules/backend/python.md lint 失敗時の当該ファイル個別検証を追記
rules/backend/database.md IntegrityError 後の再 SELECT は None 判定で RuntimeError を追記
rules/backend/architecture.md タスクハンドラの「黙って return」禁止を services/tasks 項に追記
rules/backend/layers.md CLAUDE.md 参照を整合(正本は layers.md / database.md)

テスト

doc のみの変更のため make ci(コード lint/test)対象外。Router/ORM・300/500 行・DB モック等の項目は移設先 rule に既出のため重複削除のみ。

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated internal development guidelines and workflow documentation for improved development processes and code quality standards.

Note: This release contains no user-facing changes; updates are limited to developer documentation and internal process improvements.

- CLAUDE.md「コミット / PR フロー」に PR 作成後の追従を追記
  (CI・レビュー指摘の確認→修正→再 push、意思決定/範囲逸脱は承認)
- 「失敗から学んだ知見」の領域固有項目を各 scoped rule へ移設し索引化
  - lint 個別検証 → rules/backend/python.md
  - IntegrityError 後の再 SELECT → rules/backend/database.md
  - タスクハンドラの黙って return 禁止 → rules/backend/architecture.md
- layers.md の旧 CLAUDE.md 参照を整合(正本は layers.md / database.md)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 49ba1ebd-fe8b-4e21-b2da-5a728a02c6db

📥 Commits

Reviewing files that changed from the base of the PR and between 2ac4a6c and 8d7e2d9.

📒 Files selected for processing (5)
  • .claude/CLAUDE.md
  • .claude/rules/backend/architecture.md
  • .claude/rules/backend/database.md
  • .claude/rules/backend/layers.md
  • .claude/rules/backend/python.md

📝 Walkthrough

Walkthrough

CLAUDE.md adds a "pr 後の追従" workflow step and consolidates previously inline cross-cutting rules into references to scoped files. Four scoped backend rule files each receive one new rule: task handler error propagation, IntegrityError re-SELECT behavior, layers self-reference correction, and targeted ruff check usage.

Changes

AI Rules Reorganization and New Backend Rules

Layer / File(s) Summary
CLAUDE.md: PR follow-up workflow step and rule consolidation
.claude/CLAUDE.md
Adds a new "pr 後の追従" row to the workflow table covering CI/comment inspection commands, CI-fix iteration loop, and an approval gate distinguishing mechanical fixes from design/API/behavior changes. Removes domain-specific bullet rules from "失敗から学んだ知見" and replaces them with pointers to scoped backend and web rule files, retaining only two cross-cutting items.
Scoped backend rules: task handler, IntegrityError, layers reference, lint scoping
.claude/rules/backend/architecture.md, .claude/rules/backend/database.md, .claude/rules/backend/layers.md, .claude/rules/backend/python.md
Adds rule prohibiting silent return in task handlers, requiring NonRetryableError/RetryableError raises. Adds rule that re-SELECT returning None after IntegrityError must raise RuntimeError. Updates layers.md to point to itself as source of truth and fixes its inline comment reference from CLAUDE.md to database.md. Adds guidance to scope ruff check to touched files when pre-existing violations block make lint-backend.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • yusuke0610/devforge#297: Also modifies .claude/CLAUDE.md workflow guidance and retains the rule to create branches from origin/main, which is one of the two cross-cutting items kept in this PR's consolidation.

Poem

🐇 Hoppity-hop, the rules get a trim,
Scoped files now carry each backend whim.
PR checks loop till the CI turns green,
Silent returns? NonRetryableError convene!
With ruff check targeted and RuntimeError clear,
The rule docs sparkle — all tidy from here! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main changes: adding PR follow-up rules and converting failure knowledge into scoped rule files, which matches the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/claude-pr-followup-rules-split

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yusuke0610
yusuke0610 merged commit ef2dfe5 into main Jun 22, 2026
18 checks passed
@yusuke0610
yusuke0610 deleted the docs/claude-pr-followup-rules-split branch July 20, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant