refactor(backend): GitHubLinkCache の直クエリを repository へ集約

[yusuke0610]

概要

BE_refacter の指摘（report/BE_report_20260627_2044.md）の High + Medium を適用。GitHubLinkCache の filter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

• repositories/github_link.py（新規）に GitHubLinkCacheRepository を新設（get_by_user / get_or_create）。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeError（database.md「IntegrityError 後の再 SELECT は None を判定」準拠）。
• 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B（router への DB クエリ直書き）違反を解消。

Medium

• routers/github_link.py を package 化（__init__ / endpoints / _responses）。HTTP 出力整形 to_skill_item を _responses.py へ分離（duplication.md ヒエラルキー準拠）。__init__ が router を re-export するため呼び出し側は無改修。
• chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変。

テスト

• tests/test_github_link_cache_repository.py（新規・5 ケース）。正常系に加え、競合パス（IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError）を実 SQLite セッションで検証。

補足

• app/db/bootstrap.py の bulk status クリーンアップ（cross-user・status フィルタ）は user_id 単一行 API の責務外のため対象外（次 PR 候補）。
• レポートの Low は「現状維持が正解」のため見送り。

検証

• make lint-backend: pass
• make test-backend: pass（632 passed）
• make codegen-types: web/src/api/generated.ts 差分なし（OpenAPI drift なし）

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Improved GitHub link handling across the app, including safer cache creation and reuse.
  • GitHub skill results are now formatted more consistently in API responses.

• Bug Fixes

  • Reduced duplicate cache records during concurrent requests.
  • Standardized progress, retry, and status checks for GitHub link workflows.

• Tests

  • Added coverage for cache lookup, creation, race conditions, and error handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)

• backend/app/repositories/__init__.py
• backend/app/repositories/github_link.py
• backend/app/routers/github_link/__init__.py
• backend/app/routers/github_link/_responses.py
• backend/app/routers/github_link/endpoints.py
• backend/app/services/agent/chat_service.py
• backend/app/services/agent/context_builder.py
• backend/app/services/intelligence/github_link_service.py
• backend/app/services/tasks/handlers/github_link.py
• backend/tests/test_github_link_cache_repository.py

---

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)	Summary
Repository implementation and tests backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py	GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py	The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py	GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)	Summary
Shared generation accounting backend/app/services/agent/chat_service.py	run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/github-link-cache-repo

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}