Skip to content

Use buffer_tobytes on non-object types in test #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakirkham merged 2 commits into from
Nov 9, 2018
Merged

Use buffer_tobytes on non-object types in test #122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98e28b8
Use `buffer_tobytes` on non-`object` types in test
jakirkham Nov 9, 2018
1d2fbf5
Coerce buffer to bytes only when it is needed
jakirkham Nov 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions numcodecs/tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ def check_backwards_compatibility(codec_id, arrays, codecs, precision=None, pref
# setup
i = int(arr_fn.split('.')[-2])
arr = np.load(arr_fn)
arr_bytes = buffer_tobytes(arr)
if arr.flags.f_contiguous:
order = 'F'
else:
Expand Down Expand Up @@ -233,7 +232,7 @@ def check_backwards_compatibility(codec_id, arrays, codecs, precision=None, pref
assert_array_items_equal(arr, dec_arr)
else:
assert_array_equal(arr, dec_arr)
assert arr_bytes == buffer_tobytes(dec)
assert buffer_tobytes(arr) == buffer_tobytes(dec)


def check_err_decode_object_buffer(compressor):
Expand Down