Skip to content

Added website link#1212

Closed
steph237 wants to merge 1 commit into
zarr-developers:mainfrom
steph237:added-website-link
Closed

Added website link#1212
steph237 wants to merge 1 commit into
zarr-developers:mainfrom
steph237:added-website-link

Conversation

@steph237

Copy link
Copy Markdown
Contributor

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@steph237 steph237 mentioned this pull request Oct 23, 2022
2 tasks

@joshmoore joshmoore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @steph237. Thanks for the PR! I think, however, that you've unintentionally added some files here. See the screenshot below. It looks like you were testing locally and created an a.zarr and a b.zarr dataset which were committed. If you can remove those, it will be much easier to review your change.

Screen Shot 2022-10-23 at 19 19 42

@steph237

Copy link
Copy Markdown
Contributor Author

Hi @steph237. Thanks for the PR! I think, however, that you've unintentionally added some files here. See the screenshot below. It looks like you were testing locally and created an a.zarr and a b.zarr dataset which were committed. If you can remove those, it will be much easier to review your change.

Screen Shot 2022-10-23 at 19 19 42

@joshmoore Thank you for the review, I have removed the files

@joshmoore joshmoore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @steph237. Thanks for removing the files. In some repositories, you might be asked to "undo" or "rollback" the changes. (Here it's ok since we "squash" all the changes before committing them)

Can you please restore the "contributing.rst" file and revert back the "basepython" change?

Thanks.

Screen Shot 2022-10-24 at 08 12 25

@steph237

steph237 commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

@joshmoore I opened another Pr from the feedback I got. #1216

@joshmoore

Copy link
Copy Markdown
Member

@joshmoore can i close this PR and open another just with the files which I have changed and with all the feedback ?

Definitely. That would be fine. But since I'm here....

Closing in favor of #1216

@joshmoore joshmoore closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants