base64 encode fill value for some dtypes with zarr_format=2#2286
Merged
TomAugspurger merged 7 commits intoOct 7, 2024
Merged
Conversation
TomAugspurger
commented
Oct 1, 2024
4 tasks
TomAugspurger
marked this pull request as ready for review
October 2, 2024 19:40
Contributor
Author
|
This should be ready to go (the CI failure is from appveyor). |
zarr_format=2zarr_format=2
Contributor
|
were we not doing this in the v2 codebase? I couldn't find code for it. |
Contributor
Author
|
I found it at Line 215 in 6b9ab9e |
d-v-b
reviewed
Oct 4, 2024
Member
|
Thanks Tom! 🙏 JFYI we have a |
rabernat
approved these changes
Oct 7, 2024
Contributor
Author
|
Thanks John. I think this version (rather than numcodec's) is OK. It ends up using the same actual implementation of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2282
Needs more tests.