Skip to content

Avoid memory copy in local store write #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAugspurger merged 5 commits into from
Apr 3, 2025
Merged

Avoid memory copy in local store write #2944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74db438
Avoid memory copy in local store write
tomwhite Mar 26, 2025
22592ec
Update src/zarr/storage/_local.py
tomwhite Apr 3, 2025
6ad144d
Update src/zarr/storage/_local.py
tomwhite Apr 3, 2025
8d633d2
Add comment explaining file write method takes any object supporting …
tomwhite Apr 3, 2025
45b2b55
Add changelog entry
tomwhite Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2944.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Avoid an unnecessary memory copy when writing Zarr to a local file
6 changes: 4 additions & 2 deletions src/zarr/storage/_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,17 @@ def _put(
if start is not None:
with path.open("r+b") as f:
f.seek(start)
f.write(value.as_numpy_array().tobytes())
# write takes any object supporting the buffer protocol
f.write(value.as_numpy_array()) # type: ignore[arg-type]
return None
else:
view = memoryview(value.as_numpy_array().tobytes())
view = memoryview(value.as_numpy_array()) # type: ignore[arg-type]
if exclusive:
mode = "xb"
else:
mode = "wb"
with path.open(mode=mode) as f:
# write takes any object supporting the buffer protocol
return f.write(view)


Expand Down