Fix AsyncGroup.create_dataset() dtype handling and optimize tests #3050#3059
Fix AsyncGroup.create_dataset() dtype handling and optimize tests #3050#3059dhruvak001 wants to merge 8 commits into
Conversation
|
pre-commit.ci autofix |
|
HI @d-v-b can you please review the PR. Also do I need to make separate tests for this code changes? |
DimitriPapadopoulos
left a comment
There was a problem hiding this comment.
Perhaps two distinct PRs would have been preferable, but I'm not maintainer so you can keep it as is for now.
|
i'll look at this later today |
|
can you explain some of the changes to the hypothesis tests? |
|
@d-v-b When running tests locally, I was encountering issue with slow test running or test running more than the default deadline for some particular tests. I tried some changes with the fix but still it was the same. Hence I tried to avoid and optimize the test codes. |
|
@dhruvak001 can we see what happens in our CI tests if you roll back the changes to the hypothesis tests? |
|
@d-v-b yup it passes even after reverting changes. Thankyou. |
4fccfb8 to
798132f
Compare
Fixes #3050
Core Fix in
AsyncGroup.create_dataset():-- If
dtypeis not provided in the arguments-- And
if data is None(meaning no data is being provided to infer the dtype from)-- Then raise a clear error message saying "
dtypemust be provided ifdata is None"create_array()always receives the requireddtypeparameter, preventing potential errors downstreamPlease let me know if there is any changes needed in the issue fix.
TODO:
docs/user-guide/*.rstchanges/