Skip to content

Fix V3 time types #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-v-b merged 1 commit into from
May 7, 2026
Merged

Fix V3 time types #3955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/zarr/core/dtype/npy/time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import numpy as np
from typing_extensions import ReadOnly

from zarr.core.common import NamedConfig
from zarr.core.common import NamedRequiredConfig
from zarr.core.dtype.common import (
DataTypeValidationError,
DTypeConfig_V2,
Expand Down Expand Up @@ -111,14 +111,14 @@ class TimeConfig(TypedDict):
scale_factor: ReadOnly[int]


class DateTime64JSON_V3(NamedConfig[Literal["numpy.datetime64"], TimeConfig]):
class DateTime64JSON_V3(NamedRequiredConfig[Literal["numpy.datetime64"], TimeConfig]):
"""
The JSON representation of the ``numpy.datetime64`` data type in Zarr V3.

References
----------
This representation is defined in the ``numpy.datetime64``
[specification document](https://zarr-specs.readthedocs.io/en/latest/spec/v3/datatypes.html#numpy-datetime64).
[specification document](https://github.com/zarr-developers/zarr-extensions/tree/main/data-types/numpy.datetime64).

Examples
--------
Expand All @@ -128,20 +128,20 @@ class DateTime64JSON_V3(NamedConfig[Literal["numpy.datetime64"], TimeConfig]):
"configuration": {
"unit": "ms",
"scale_factor": 1
}
}
}
```
"""


class TimeDelta64JSON_V3(NamedConfig[Literal["numpy.timedelta64"], TimeConfig]):
class TimeDelta64JSON_V3(NamedRequiredConfig[Literal["numpy.timedelta64"], TimeConfig]):
"""
The JSON representation of the ``TimeDelta64`` data type in Zarr V3.

References
----------
This representation is defined in the numpy.timedelta64
[specification document](https://zarr-specs.readthedocs.io/en/latest/spec/v3/datatypes.html#numpy-timedelta64).
[specification document](https://github.com/zarr-developers/zarr-extensions/tree/main/data-types/numpy.timedelta64).

Examples
--------
Expand All @@ -151,7 +151,7 @@ class TimeDelta64JSON_V3(NamedConfig[Literal["numpy.timedelta64"], TimeConfig]):
"configuration": {
"unit": "ms",
"scale_factor": 1
}
}
}
```
"""
Expand Down
Loading