Skip to content

Add xtensor-zarr#23

Merged
constantinpape merged 1 commit into
zarr-developers:masterfrom
davidbrochart:xtensor-zarr
Mar 24, 2021
Merged

Add xtensor-zarr#23
constantinpape merged 1 commit into
zarr-developers:masterfrom
davidbrochart:xtensor-zarr

Conversation

@davidbrochart

Copy link
Copy Markdown
Contributor

No description provided.

@davidbrochart

Copy link
Copy Markdown
Contributor Author

Trigger CI

@davidbrochart davidbrochart reopened this Mar 24, 2021
@davidbrochart

Copy link
Copy Markdown
Contributor Author

It looks like the failures are due to the grid overhanging the edge of the array space, e.g. chunk 5.5.0 with shape (100, 100, 1) has unused data since only the slice (:12, :12, :1) is relevant. xtensor-zarr doesn't store the unused data, which looks like a bug.

@joshmoore

Copy link
Copy Markdown
Member

One point for zarr_implementations! 🎉 Really excited to have xtensor added here, @davidbrochart.

@davidbrochart

Copy link
Copy Markdown
Contributor Author

Indeed Josh, this exercise was useful! We have a fix coming 😄

@constantinpape constantinpape left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Do you want to add anything else, @davidbrochart? Otherwise I am very happy to merge this :).

Also, we should eventually add a test that reads the other zarr data with xtensor-zarr, but this is currently also lacking for the other non-python implementations, see #25.
So from my side it's totally ok to do this later in another PR.

@davidbrochart

Copy link
Copy Markdown
Contributor Author

Yes, I think we can merge this PR and I'll open another one for reading other zarr data with xtensor-zarr.

@constantinpape
constantinpape merged commit 7dfbd9a into zarr-developers:master Mar 24, 2021
@davidbrochart
davidbrochart deleted the xtensor-zarr branch March 24, 2021 20:49
@grlee77

grlee77 commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

I tried extending the data generation program to also generate an xtensor_zarr.zr3 v3 format file as well, but haven't succeeded yet. I opened an issue regarding it at xtensor-stack/xtensor-zarr#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants