Skip to content

Conversation

@psprint
Copy link
Contributor

@psprint psprint commented Jul 28, 2023

The m function is automatically provided for the moment of loading/installing a plugin and it's the same as +zinit-message.

Description

Allow theming of bin-gem-node messages.

Motivation and Context

There is a problem because the color codes are currently hard-coded into bin-gem-node. With this patch, the messages will make use of +zinit-message theming.

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@psprint
Copy link
Contributor Author

psprint commented Jul 29, 2023

@vladdoster @pschmitt @alichtman ping

@vladdoster
Copy link
Member

Please use +zi-log instead of m. m gives developers no information about what it does.

@vladdoster vladdoster self-requested a review August 22, 2023 02:29
@psprint
Copy link
Contributor Author

psprint commented Aug 22, 2023

Please use +zi-log instead of m. m gives developers no information about what it does.

@vladdoster I've switched to +zi-log. That said, it would be good to document m function. It's designed to be used in atclone/atpull ices, to maximally shorten the code entered into them.

The `m` function is automatically provided for the moment of loading/installing
a plugin and it's the same as `+zinit-message`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants