Skip to content

Decompile 00_Core/Map/MapBase.cpp (62%)#137

Open
SammygoodTunes wants to merge 11 commits into
zeldaret:mainfrom
SammygoodTunes:decomp/MapBase
Open

Decompile 00_Core/Map/MapBase.cpp (62%)#137
SammygoodTunes wants to merge 11 commits into
zeldaret:mainfrom
SammygoodTunes:decomp/MapBase

Conversation

@SammygoodTunes
Copy link
Copy Markdown
Contributor

@SammygoodTunes SammygoodTunes commented Sep 24, 2025

Decompilation of src/00_Core/Map/MapBase.cpp (part 2)

Type Progress
.data 31%
.sbss 50%
.text 62%

(According to objdiff v3.5.1)

@SammygoodTunes SammygoodTunes marked this pull request as draft September 24, 2025 12:46
@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Sep 24, 2025

Report for usa (0bb7400 - 035f630)

📈 Matched code: 2.75% (+0.01%, +292 bytes)

✅ 8 new matches
Unit Item Bytes Before After
src/00_Core/Map/MapBase MapBase::vfunc_90(TilePos*, int) +74 66.36% 100.00%
src/00_Core/Map/MapBase MapBase_func_ov00_0207e940::~MapBase_func_ov00_0207e940() +40 0.00% 100.00%
src/00_Core/Map/MapManager MapManager::GetOverlappingTrigger(Vec3p*) +16 0.00% 100.00%
src/00_Core/Map/MapManager MapManager::func_ov00_020838f8(Exit*) +16 0.00% 100.00%
src/00_Core/Map/MapBase MapBase::vfunc_5c(TilePos*) +8 0.00% 100.00%
src/00_Core/Map/MapBase MapBase_func_ov00_0207e968::~MapBase_func_ov00_0207e968() +4 0.00% 100.00%
src/00_Core/Map/MapBase MapBase::vfunc_bc(TilePos*, int) +4 0.00% 100.00%
src/00_Core/Map/MapBase MapBase::vfunc_c0(TilePos*, int) +4 0.00% 100.00%
🥀 4 broken matches
Unit Item Bytes Before After
src/00_Core/Map/MapBase MapBase::vfunc_5c() -8 100.00% 0.00%
src/00_Core/Map/MapBase MapBase::func_ov00_0207e968() -4 100.00% 0.00%
src/00_Core/Map/MapBase MapBase::vfunc_bc() -4 100.00% 0.00%
src/00_Core/Map/MapBase MapBase::vfunc_c0() -4 100.00% 0.00%
📈 14 improvements in unmatched items
Unit Item Bytes Before After
src/00_Core/Map/MapBase MapBase::func_ov00_0207e0f0(int) +102 74.87% 99.57%
src/00_Core/Map/MapBase MapBase::AddEntrance(Entrance*) +40 29.48% 61.94%
src/00_Core/Map/MapBase MapBase::AddCameraViewpoint(CameraViewpoint*) +32 54.20% 73.49%
src/00_Core/Map/MapBase MapBase::AddExit(Exit*) +31 61.93% 80.98%
src/00_Core/Map/MapManager MapManager::func_ov00_02082e1c(int*, int*) +28 68.55% 73.24%
src/00_Core/Map/MapBase MapBase::func_ov00_0207e08c(int*, int) +27 71.16% 98.40%
src/00_Core/Map/MapManager MapManager::func_ov00_02086044(Vec3p*, Vec3p*, int) +26 45.12% 49.62%
src/00_Core/Map/MapBase MapBase::AddTrigger(TriggerBase*) +24 47.65% 56.73%
src/00_Core/Map/MapBase MapBase::AddUnk_130(TriggerBase*) +24 45.00% 55.43%
src/00_Core/Map/MapBase MapBase::func_ov00_0207ff88(TriggerBase*) +22 35.60% 45.91%
src/00_Core/Map/MapBase MapBase::func_ov00_02080140(Exit*) +16 65.34% 68.73%
src/00_Core/Map/MapBase MapBase::func_ov00_020809b8(TriggerBase*) +14 35.25% 42.67%
src/00_Core/Map/MapBase MapBase::GetTileBounds(TilePos*, AABB*) +5 69.40% 72.19%
src/00_Core/Map/MapBase MapBase::func_ov00_02080824(unsigned int, char*) 0 95.81% 95.93%
📉 6 regressions in unmatched items
Unit Item Bytes Before After
src/00_Core/Map/MapManager MapManager::func_ov00_02085c60(UnkStruct*, int*, int*, unsigned int) -645 64.77% 0.00%
src/00_Core/Map/MapBase MapBase::vfunc_6c(Vec3p*, int*, Vec3p*) -67 42.13% 36.47%
src/00_Core/Map/MapBase MapBase::vfunc_70(Vec3p*) -39 49.21% 41.12%
src/00_Core/Map/MapBase MapBase::vfunc_68(Vec3p*, bool) -8 38.18% 37.47%
src/00_Core/Map/MapBase MapBase::AddTrigger(TriggerParams*) -2 82.13% 81.31%
src/00_Core/Map/MapBase MapBase::func_ov00_0207e940(char*) -1 4.00% 0.00%

Report for eur (0bb7400 - 035f630)

📈 Matched code: 2.77% (+0.01%, +292 bytes)

✅ 8 new matches
Unit Item Bytes Before After
src/00_Core/Map/MapBase MapBase::vfunc_90(TilePos*, int) +74 66.36% 100.00%
src/00_Core/Map/MapBase MapBase_func_ov00_0207e940::~MapBase_func_ov00_0207e940() +40 0.00% 100.00%
src/00_Core/Map/MapManager MapManager::GetOverlappingTrigger(Vec3p*) +16 0.00% 100.00%
src/00_Core/Map/MapManager MapManager::func_ov00_020838f8(Exit*) +16 0.00% 100.00%
src/00_Core/Map/MapBase MapBase::vfunc_5c(TilePos*) +8 0.00% 100.00%
src/00_Core/Map/MapBase MapBase_func_ov00_0207e968::~MapBase_func_ov00_0207e968() +4 0.00% 100.00%
src/00_Core/Map/MapBase MapBase::vfunc_bc(TilePos*, int) +4 0.00% 100.00%
src/00_Core/Map/MapBase MapBase::vfunc_c0(TilePos*, int) +4 0.00% 100.00%
🥀 4 broken matches
Unit Item Bytes Before After
src/00_Core/Map/MapBase MapBase::vfunc_5c() -8 100.00% 0.00%
src/00_Core/Map/MapBase MapBase::func_ov00_0207e968() -4 100.00% 0.00%
src/00_Core/Map/MapBase MapBase::vfunc_bc() -4 100.00% 0.00%
src/00_Core/Map/MapBase MapBase::vfunc_c0() -4 100.00% 0.00%
📈 14 improvements in unmatched items
Unit Item Bytes Before After
src/00_Core/Map/MapBase MapBase::func_ov00_0207e0f0(int) +102 74.87% 99.57%
src/00_Core/Map/MapBase MapBase::AddEntrance(Entrance*) +40 29.48% 61.94%
src/00_Core/Map/MapBase MapBase::AddCameraViewpoint(CameraViewpoint*) +32 54.20% 73.49%
src/00_Core/Map/MapBase MapBase::AddExit(Exit*) +31 61.93% 80.98%
src/00_Core/Map/MapManager MapManager::func_ov00_02082e1c(int*, int*) +28 68.55% 73.24%
src/00_Core/Map/MapBase MapBase::func_ov00_0207e08c(int*, int) +27 71.16% 98.40%
src/00_Core/Map/MapManager MapManager::func_ov00_02086044(Vec3p*, Vec3p*, int) +26 45.12% 49.62%
src/00_Core/Map/MapBase MapBase::AddTrigger(TriggerBase*) +24 47.65% 56.73%
src/00_Core/Map/MapBase MapBase::AddUnk_130(TriggerBase*) +24 45.00% 55.43%
src/00_Core/Map/MapBase MapBase::func_ov00_0207ff88(TriggerBase*) +22 35.60% 45.91%
src/00_Core/Map/MapBase MapBase::func_ov00_02080140(Exit*) +16 65.34% 68.73%
src/00_Core/Map/MapBase MapBase::func_ov00_020809b8(TriggerBase*) +14 35.25% 42.67%
src/00_Core/Map/MapBase MapBase::GetTileBounds(TilePos*, AABB*) +5 69.40% 72.19%
src/00_Core/Map/MapBase MapBase::func_ov00_02080824(unsigned int, char*) 0 95.81% 95.93%
📉 5 regressions in unmatched items
Unit Item Bytes Before After
src/00_Core/Map/MapBase MapBase::vfunc_6c(Vec3p*, int*, Vec3p*) -67 42.13% 36.47%
src/00_Core/Map/MapBase MapBase::vfunc_70(Vec3p*) -39 49.21% 41.12%
src/00_Core/Map/MapBase MapBase::vfunc_68(Vec3p*, bool) -8 38.18% 37.47%
src/00_Core/Map/MapBase MapBase::AddTrigger(TriggerParams*) -2 82.13% 81.31%
src/00_Core/Map/MapBase MapBase::func_ov00_0207e940(char*) -1 4.00% 0.00%

@SammygoodTunes SammygoodTunes changed the title Decompile 00_Core/Map/MapBase.cpp (57%) Decompile 00_Core/Map/MapBase.cpp (62%) Feb 27, 2026
@SammygoodTunes
Copy link
Copy Markdown
Contributor Author

I'll take a break on this, for the time being, to work on something smaller. A lot of the functions (especially the larger ones) are in a non-matching state. I may come back to this later on once I've learnt a bit more.

@SammygoodTunes SammygoodTunes marked this pull request as ready for review May 15, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant