Skip to content

Conversation

@iabdalkader
Copy link
Contributor

@iabdalkader iabdalkader commented Nov 30, 2025

Add ITCM and DTCM memory region definitions for the STM32H7.

ITCM: 64 KB @ 0x00000000
DTCM: 128 KB @ 0x20000000

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the search I've just made, all STM32H7 based soc use 64/128K ITCM/DTCM.
Unless I'm wrong, it would be better to put it directly in h7.dtsi (and delete node from m4 cores).

@iabdalkader
Copy link
Contributor Author

it would be better to put it directly in h7.dtsi (and delete node from m4 cores).

We'll also need to delete any itcm/dtcm defined by _m7 files. This will be a much bigger change, 10+ files, is that okay?

@erwango
Copy link
Member

erwango commented Dec 2, 2025

This will be a much bigger change, 10+ files, is that okay?

Sure indeed, a complete clean up is required. Thanks !

delete node from m4 cores

To be clear, I meant explicitly use /delete-node/ directive in _m4.dtsi files to preserve existing configuration avoid resource sharing conflicts.

@iabdalkader iabdalkader changed the title dts: arm: st: h7: add ITCM and DTCM memory regions for STM32H747 M7 dts: arm: st: h7: add ITCM and DTCM memory regions for STM32H7 Dec 2, 2025
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

But please merge all your commits (at the minimum #1 and #3) as having them split will break bisectability (it won't compile due to duplicated nodes)

Add ITCM and DTCM memory region definitions to the common STM32H7
devicetree.

ITCM: 64 KB @ 0x00000000
DTCM: 128 KB @ 0x20000000

Signed-off-by: Ibrahim Abdalkader <i.abdalkader@gmail.com>
Delete the ITCM and DTCM nodes from all M4-specific devicetree.

Signed-off-by: Ibrahim Abdalkader <i.abdalkader@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find a H7 that is not compatible with this setting from datasheet.

Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct per ST Product Selector (which seems to have a bug making no TCM appear despite some products having it... glanced at a few datasheets too)

@nashif nashif merged commit 78429c8 into zephyrproject-rtos:main Dec 2, 2025
26 checks passed
@iabdalkader iabdalkader deleted the add_h747_dtcm_itcm branch December 3, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants