fix(memory): skip [Memory context] blobs in auto_save#4936
Open
rareba wants to merge 3 commits intozeroclaw-labs:masterfrom
Open
fix(memory): skip [Memory context] blobs in auto_save#4936rareba wants to merge 3 commits intozeroclaw-labs:masterfrom
rareba wants to merge 3 commits intozeroclaw-labs:masterfrom
Conversation
rareba
requested review from
JordanTheJet,
SimianAstronaut7 and
theonlyhennygod
as code owners
github-actions
bot
added
memory
SimianAstronaut7
force-pushed
the
master
branch
from
c3ff635 to
1362d69
Compare
rareba
force-pushed
the
fix/4916-memory-context-autosave-skip
branch
from
d826aaf to
98aabd8
Compare
…rsive snowball When auto_save is enabled, the memory_recall tool's output (prefixed with [Memory context]) was being persisted back into brain.db as a new entry. Each successive recall then retrieved the growing blob, creating exponential memory growth that eventually exhausts resources. Add [Memory context] to the should_skip_autosave_content filter, matching the existing treatment for [cron:], [heartbeat task], and [distilled_] prefixes. Closes zeroclaw-labs#4916
rareba
force-pushed
the
fix/4916-memory-context-autosave-skip
branch
from
98aabd8 to
0525c17
Compare
github-actions
bot
removed
agent
- Remove unused `has_successful_images` variable (multimodal.rs) - Collapse nested `if` statements (namespaced.rs) - Merge match arms with identical bodies (web_search_tool.rs) - Extract type alias for complex closure type (wrappers.rs) - Elide needless lifetime annotation (wrappers.rs) - Add separator to hex literal, gate TempDir import (schema.rs) - Fall back to simple chat when full agent loop fails (gateway/mod.rs) - Ignore RUSTSEC-2024-0370 proc-macro-error unmaintained advisory
github-actions
bot
added
core
unicode-segmentation 1.13.1 is yanked but pulled in transitively by tao/keyboard-types (tauri desktop). No upstream fix available yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4916
When
auto_save = true(default), thememory_recalltool output (prefixed with[Memory context]) was being saved back intobrain.dbas a new memory entry. Each recall then retrieved the growing blob, creating exponential memory growth (recursive snowball) that exhausts resources.Root Cause
should_skip_autosave_content()filters[cron:],[heartbeat task], and[distilled_]prefixes but did not filter[Memory context]blobs.Fix
Add
[memory context](case-insensitive) to the skip list inshould_skip_autosave_content().Test plan
[Memory context]blob inautosave_content_filter_drops_cron_and_distilled_noise