Conversation
pascal-giguere
commented
Mar 23, 2021
pascal-giguere
commented
Mar 23, 2021
pascal-giguere
commented
Mar 23, 2021
|
|
||
| Include instructions on how to run your app, and a list of what features you implemented. Add any comments or things you | ||
| want the reviewer to consider when looking at your submission. You don't need to be too detailed, as there will likely | ||
| be a review done with you where you can explain what you've done. |
Contributor
Author
There was a problem hiding this comment.
As suggested by @amerski99, we might want to remove the Submission instructions section from this readme and include this content in the communication candidates are sent.
ghost
reviewed
Mar 23, 2021
ghost
reviewed
Mar 23, 2021
ghost
approved these changes
Mar 23, 2021
amerski99
approved these changes
Mar 24, 2021
README.md
Outdated
| Take *propertyId* and *distance* (in meters) as inputs. The API should return the following: | ||
| * parcel area (meters squared) | ||
| * buildings areas (array, meters squared) | ||
| * buildings distances to center (array, meters squared). Distance to center is the distance from the building to the |
Contributor
There was a problem hiding this comment.
Should be meters, not meters squared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge of the front-end end back-end exercises, now with features split between required and optional. 4 hours to implement required features, or more if implementing optional features.