Summary
charts/studio/templates/deployment.yaml (line 48) sets the env var PUBLIC_WORKFLOWS_DATA_DIR, but the SvelteKit code reads PUBLIC_WORKFLOWS_DIR:
src/lib/server/workflows-dir.ts — env.PUBLIC_WORKFLOWS_DIR ?? resolve(process.cwd(), 'workflows')
src/routes/workflows/+page.server.ts — same
Dockerfile line 49 — ENV PUBLIC_WORKFLOWS_DIR=/data
Today this accidentally works for the default case because (a) the Dockerfile already sets PUBLIC_WORKFLOWS_DIR=/data and (b) the chart's default dataDir: /data matches. But if someone overrides dataDir in their values, the chart silently ignores the override: the deployment env var with the wrong name is set, the real one is left at the Dockerfile default, and the workflow directory doesn't actually move.
Proposed fix
- - name: PUBLIC_WORKFLOWS_DATA_DIR
+ - name: PUBLIC_WORKFLOWS_DIR
value: {{ .Values.dataDir | quote }}
Happy to open a PR if useful.
Context
Found while alpha-testing studio on a Kubernetes cluster (vendored chart, deployed via ArgoCD). Patched in our vendored copy in the meantime.
Summary
charts/studio/templates/deployment.yaml(line 48) sets the env varPUBLIC_WORKFLOWS_DATA_DIR, but the SvelteKit code readsPUBLIC_WORKFLOWS_DIR:src/lib/server/workflows-dir.ts—env.PUBLIC_WORKFLOWS_DIR ?? resolve(process.cwd(), 'workflows')src/routes/workflows/+page.server.ts— sameDockerfileline 49 —ENV PUBLIC_WORKFLOWS_DIR=/dataToday this accidentally works for the default case because (a) the Dockerfile already sets
PUBLIC_WORKFLOWS_DIR=/dataand (b) the chart's defaultdataDir: /datamatches. But if someone overridesdataDirin their values, the chart silently ignores the override: the deployment env var with the wrong name is set, the real one is left at the Dockerfile default, and the workflow directory doesn't actually move.Proposed fix
Happy to open a PR if useful.
Context
Found while alpha-testing studio on a Kubernetes cluster (vendored chart, deployed via ArgoCD). Patched in our vendored copy in the meantime.