error: unable to unpack tarball to temporary directory: TarComponentsOutsideStrippedPrefix

[theoparis]

Zig Version

0.12.0 (gentoo 9999 version)

Steps to Reproduce and Observed Behavior

/home/theo/chromium/build.zig.zon:10:20: error: unable to unpack tarball to temporary directory: TarComponentsOutsideStrippedPrefix
.url = "https://chromium.googlesource.com/chromium/tools/depot_tools.git/+archive/refs/heads/main.tar.gz",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It seems like there may need to be some kind of way to set strip_components here.

Expected Behavior

The zig package manager should succesfully download depot_tools.

[theoparis]

I'm not sure if this should be a separate issue but using a chromium source repository with git+https instead results in

[ianprime0509]

Running curl -H 'Git-Protocol: version=2' --output - https://boringssl.googlesource.com/boringssl/info/refs?service=git-upload-pack, it looks like the Git server does actually support protocol v2, but the difference is it isn't including the LF characters which are indicated to appear at the end of certain packets in the protocol v2 spec.

However, despite what the grammar in the protocol-v2 documentation suggests, this doesn't seem to be a bug in Google's Git server: in the protocol-common documentation there is a note about this:

A non-binary line SHOULD BE terminated by an LF, which if present MUST be included in the total length. Receivers MUST treat pkt-lines with non-binary data the same whether or not they contain the trailing LF (stripping the LF if present, and not complaining when it is missing).

That means that all pkt-line handling involving textual content should be updated to be tolerant of a missing LF at the end:

zig/src/Package/Fetch/git.zig

Line 557 in e72049b

.response_start => if (mem.eql(u8, data, "version 2\n")) {

This shouldn't be too difficult to fix.

In any case, though, this is definitely a distinct issue from your original (which has to do with strip_components, as you noted).

[ianprime0509]

I opened #17974 for the second issue reported here.

[hazeycode]

Also running into this with https://zig-gamedev-pkgs.ams3.cdn.digitaloceanspaces.com/zmath-0.9.6.tar.gz

Tarball created on macOS using tar -czvf zmath-0.9.6.tar.gz -C libs/zmath .

Zig version 0.12.0-dev.1871+e426ae43a

With Zig 0.12.0-dev.2271+14efbbfd8 the error is instead:
error: unable to unpack tarball to temporary directory: BadFileName