langref: Document destructuring#21627
Conversation
87flowers
force-pushed
the
doc-destruct
branch
from
ee572b5 to
942d0e5
Compare
87flowers
force-pushed
the
doc-destruct
branch
from
942d0e5 to
d368279
Compare
rootbeer
left a comment
rootbeer
left a comment
There was a problem hiding this comment.
The new text looks reasonable to me (but I'm not enough of an expert to point out if it has subtle problems). However, I am enough of an expert to point out the missing files.
|
Thank you for your effort! Would you mind changing the text a little so that it mentions the word "unpack" somewhere? My thinking is that a new user might learn this way that the word "unpacking" maps to "destructuring" in zig. |
|
I don't think introducing additional terminology is helpful, especially an ambiguous word like 'unpack', which could also refer to vector unpacking or similar concepts. |
|
cc @mlugg since IIRC you implemented the feature? |
mlugg
left a comment
mlugg
left a comment
There was a problem hiding this comment.
Sorry, these are slight nitpicks. Once they're addressed (feel free to just have GitHub commit them and I'll squash-merge this) I'll be happy to merge since it's certainly an improvement on not having this documented.
Co-authored-by: Matthew Lugg <mlugg@mlugg.co.uk>
|
Applied as suggested, thanks! |
5 participants
Resolves #18523.