std.posix: Rewriting enums to seperate clock IDs for clock_gettime() and timerfd_create() - Follow-up#22627
Merged
Merged
Conversation
…_create() - Follow-up
alexrp
reviewed
Jan 27, 2025
alexrp
reviewed
Jan 27, 2025
alexrp
reviewed
Jan 27, 2025
alexrp
reviewed
Jan 27, 2025
alexrp
reviewed
Jan 27, 2025
alexrp
reviewed
Jan 27, 2025
alexrp
reviewed
Jan 27, 2025
alexrp
reviewed
Jan 27, 2025
Member
|
Looks ok to me now. Let's see what CI says. |
alexrp
reviewed
Jan 29, 2025
alexrp
reviewed
Jan 29, 2025
alexrp
approved these changes
Jan 29, 2025
Member
alexrp
left a comment
alexrp
left a comment
There was a problem hiding this comment.
Thanks; LGTM.
A cleanup opportunity here is to remove the CLOCK/TIMERFD_CLOCK aliases since I'm not convinced they add any value over just using the clockid_t/timerfd_clockid_t enums directly. But since CLOCK was already here, such a change can be a future PR.
Contributor
Author
agree |
Contributor
Author
|
Looks like aarch64-windows ci doesn't work? |
Member
|
It's just catching up. It's by far our slowest CI machine and it's been very busy over the past few days due to merging a lot of PRs. |
Contributor
Author
|
Didn't work, no runner were available within 1 day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR of #21347, as it was accidentally deleted.
Incorporated the latest suggestions from @alexrp to better distinguish
CLOCKforclock_gettime()andTIMERFD_CLOCKfortimerfd_create().fixes #20334