std.debug: allow fp unwind from context#25866
Merged
Merged
Conversation
Member
|
The CI failures are happening because of a mismatch between register size and pointer size for N32 and x32. You can just Alternatively, I guess there's an argument to be made for |
Member
|
Since it looks like it'll land first, note that #25886 adds pub fn getFp(ctx: *const Kvx) u64 {
return ctx.r[14];
}
pub fn getPc(ctx: *const Kvx) u64 {
return ctx.pc;
} |
It's easy to do FP unwinding from a CPU context: you just report the captured ip/pc value first, and then unwind from the captured fp value. All this really needed was a couple of new functions on the `std.debug.cpu_context` implementations so that we don't need to rely on `std.debug.Dwarf` to access the captured registers. Resolves: ziglang#25576
8dbcb2f to
6b61655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's easy to do FP unwinding from a CPU context: you just report the captured ip/pc value first, and then unwind from the captured fp value. All this really needed was a couple of new functions on the
std.debug.cpu_contextimplementations so that we don't need to rely onstd.debug.Dwarfto access the captured registers.Resolves: #25576