Use std.math.isPowerOfTwo across std lib#2648
Merged
Merged
Conversation
squeek502
force-pushed
the
is-power-of-two
branch
from
f3d92f7 to
c943e9d
Compare
andrewrk
reviewed
Jun 10, 2019
squeek502
force-pushed
the
is-power-of-two
branch
from
c943e9d to
d3db480
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that
std.math.isPowerOfTwogot added in #2525 and so I went through and tried to find all instances of that logic and replace it with a call to that function.Only instance I found that I didn't replace is this one:zig/std/special/compiler_rt/udivmod.zig
Line 67 in b7811d3
because it doesn't currently@import("std")and I wasn't sure if that was okay to add that to that file.EDIT: Nevermind, it actually did
@import("std"), just not at the top. Made that file usestd.math.isPowerOfTwoas well.EDIT#2: Left
compiler_rt/udivmod.zigunchanged, see comments.