Build.zig: Skip copying files that are used internally by the compiler#6510
Merged
Conversation
Before this it was trying to copy all the files from the zig-cache dir to the output dir, but in the current compiler architecture the cache dir is also used for internal compiler files.
Member
|
Let me tackle this one please. Sorry about the regression |
Member
|
Thanks @FireFox317 - this is a nice solution until we can re-evaluate this code and think about how it should work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might not be the best solution and would require some rework in the compiler to make sure that it uses a different cache directory for the internal files. But it does fix the issue
Closes #6493