Skip to content

Converted item detail abstract to UITextView so that the abstract is selectable#1264

Merged
michalrentka merged 3 commits intozotero:masterfrom
michalrentka:abstract_improvements
Apr 29, 2026
Merged

Converted item detail abstract to UITextView so that the abstract is selectable#1264
michalrentka merged 3 commits intozotero:masterfrom
michalrentka:abstract_improvements

Conversation

@michalrentka
Copy link
Copy Markdown
Contributor

@michalrentka michalrentka commented Apr 9, 2026

Closes #1121

@michalrentka
Copy link
Copy Markdown
Contributor Author

@dstillman fyi, I made abstract selectable, so that you can long-press it and copy/translate/share parts of it. Currently you can only select and copy the whole thing. The little downside is that you have to tap the "Show more" / "Show less" button directly instead of tapping the whole cell to expand / compact abstract.

@michalrentka michalrentka requested a review from mvasilak April 27, 2026 08:50
@michalrentka michalrentka force-pushed the abstract_improvements branch from 2b8a0d5 to 3c74b2b Compare April 27, 2026 09:42
Copy link
Copy Markdown
Contributor

@mvasilak mvasilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chage loses the recently added tap and hold menu that only had the copy action. So quick copy of the whole abstract now needs to expand and copy the whole text. Perhaps a copy button e.g. on the top right side of the cell might be a good addition.
Better yet, if possible, in collapsed state show label with copy action in context menu, as before, and in expand state adopt the text view added by this PR.

Additionally, show more and show less, can be selected along the text. It might be better to make them buttons, that are placed on top of where they would have been placed as text. This would also remove the small animation when tapping he expand link in the text view, which is a bit distracting.

@michalrentka michalrentka changed the title Converter item detail abstract to UITextView so that the abstract is selectable Converted item detail abstract to UITextView so that the abstract is selectable Apr 28, 2026
@michalrentka michalrentka force-pushed the abstract_improvements branch from 3c74b2b to 501e5b3 Compare April 28, 2026 11:55
@michalrentka
Copy link
Copy Markdown
Contributor Author

This chage loses the recently added tap and hold menu that only had the copy action. So quick copy of the whole abstract now needs to expand and copy the whole text. Perhaps a copy button e.g. on the top right side of the cell might be a good addition. Better yet, if possible, in collapsed state show label with copy action in context menu, as before, and in expand state adopt the text view added by this PR.

Good idea, I re-added "Copy" context menu when it's collapsed and kept the new functionality when expanded.

Additionally, show more and show less, can be selected along the text. It might be better to make them buttons, that are placed on top of where they would have been placed as text. This would also remove the small animation when tapping he expand link in the text view, which is a bit distracting.

Replacing with an actual button would be a bit troublesome, I exclude the link text from selection in delegate call textViewDidChangeSelection, so that you won't be able to select it.

501e5b3

@michalrentka michalrentka requested a review from mvasilak April 28, 2026 11:58
@michalrentka michalrentka merged commit d658086 into zotero:master Apr 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Make item details abstract text selectable

2 participants