Converted item detail abstract to UITextView so that the abstract is selectable#1264
Conversation
|
@dstillman fyi, I made abstract selectable, so that you can long-press it and copy/translate/share parts of it. Currently you can only select and copy the whole thing. The little downside is that you have to tap the "Show more" / "Show less" button directly instead of tapping the whole cell to expand / compact abstract. |
2b8a0d5 to
3c74b2b
Compare
mvasilak
left a comment
There was a problem hiding this comment.
This chage loses the recently added tap and hold menu that only had the copy action. So quick copy of the whole abstract now needs to expand and copy the whole text. Perhaps a copy button e.g. on the top right side of the cell might be a good addition.
Better yet, if possible, in collapsed state show label with copy action in context menu, as before, and in expand state adopt the text view added by this PR.
Additionally, show more and show less, can be selected along the text. It might be better to make them buttons, that are placed on top of where they would have been placed as text. This would also remove the small animation when tapping he expand link in the text view, which is a bit distracting.
…de "Show More"/"Show Less" from textview selection
3c74b2b to
501e5b3
Compare
Good idea, I re-added "Copy" context menu when it's collapsed and kept the new functionality when expanded.
Replacing with an actual button would be a bit troublesome, I exclude the link text from selection in delegate call |
Closes #1121