Improve annotation default page label computation#1281
Open
mvasilak wants to merge 5 commits intozotero:masterfrom
Open
Improve annotation default page label computation#1281mvasilak wants to merge 5 commits intozotero:masterfrom
mvasilak wants to merge 5 commits intozotero:masterfrom
Conversation
Contributor
mvasilak
commented
Apr 29, 2026
mvasilak
commented
- Adds tests for annotation default page label computation.
- Improves performance by using database request (more significant for attachments with a very large number of annotations).
michalrentka
approved these changes
Apr 30, 2026
| } | ||
|
|
||
| static func from(databaseAnnotations: Results<RItem>) -> Self { | ||
| var uniquePageLabelsCountByPage: [Int: [String: Int]] = [:] |
Contributor
There was a problem hiding this comment.
This logic seems to be the same/very similar to ReadDefaultAnnotationPageLabelDbRequest. Could the logic be re-used?
Contributor
Author
There was a problem hiding this comment.
This code is not used anymore, so it is removed in 4812386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.