Fix lookup with turnstile challenge#1283
Open
mvasilak wants to merge 10 commits intozotero:masterfrom
Open
Conversation
mvasilak
force-pushed
the
fix-lookup-with-turnstile-challenge
branch
from
bae61e8 to
34d0af3
Compare
michalrentka
approved these changes
May 4, 2026
|
|
||
| // MARK: - Browser Challenges | ||
|
|
||
| /// Decide whether a non-success response is a bot challenge that can be cleared in a hidden web view. |
Contributor
There was a problem hiding this comment.
Comments in this browser challenge section are a bit unrelated to actual WebViewhandler. They provide additional info for current issue, but if you read them in a few months, they don't really make sense here. In this case you're just returning nil, you don't "decide whether a non-success response is a bot challenge". "default returns nil so sendRequest behaves as before." is not a great comment either, because what is "before" when you don't have the context of this PR? Sure, you can look up the PR when checking git blame, but these comments just look confusing.
Contributor
Author
There was a problem hiding this comment.
You are right, the generated comments are too verbose and in many cases unnecessary. Check ac143c0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds hiden turnstile chalenge resolution.
Based on zotero/zotero#5890